Skip to content

Okta v2: Add revokeOauthTokens argument to okta-clear-user-sessions command#42920

Open
almog2296 wants to merge 7 commits intomasterfrom
CIAC-15065-okta-clear-user-sessions-oauth-tokens
Open

Okta v2: Add revokeOauthTokens argument to okta-clear-user-sessions command#42920
almog2296 wants to merge 7 commits intomasterfrom
CIAC-15065-okta-clear-user-sessions-oauth-tokens

Conversation

@almog2296
Copy link
Contributor

@almog2296 almog2296 commented Feb 4, 2026

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-15065

Description

Added a new optional revokeOauthTokens argument to the okta-clear-user-sessions command that allows revoking OpenID Connect and OAuth refresh/access tokens in addition to clearing user sessions.

@content-bot
Copy link
Contributor

content-bot commented Feb 4, 2026

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @content-bot start review - Initiate a full AI code review
  • @content-bot re-review - Incremental review for new commits

@github-actions
Copy link

github-actions bot commented Feb 4, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Okta/Integrations/Okta_v2
   Okta_v2.py75431757%72–77, 86, 92–93, 96–97, 100–101, 104–105, 108–109, 116–117, 136–137, 140–141, 144–145, 206–208, 215–216, 223–224, 231–239, 243–244, 247–249, 271, 277–280, 283–284, 330, 355–356, 359–362, 365, 368–369, 398, 400, 404–406, 409–413, 416–419, 422–426, 430–445, 448–453, 457–465, 472, 483–484, 492–493, 496–500, 503–504, 507–508, 510, 513–514, 518, 520, 523, 525–526, 530–532, 536, 538, 546–548, 552–553, 557–559, 563, 565, 573–575, 579–580, 584–586, 590–591, 598, 605, 618–619, 621–622, 624–625, 627–628, 631–632, 678–679, 681–690, 693–694, 698–699, 701–710, 713–714, 742, 786–792, 794–798, 802–803, 805–807, 810, 815, 826, 851, 864–869, 872–873, 878, 882, 892, 917–920, 924, 926, 932, 935, 947–950, 953–956, 960, 964–967, 970–973, 977, 981–984, 987–990, 994, 998–1001, 1004–1007, 1011, 1015–1017, 1021–1025, 1028–1029, 1047, 1050, 1064, 1067, 1110, 1122, 1129, 1132, 1145, 1157, 1160, 1171, 1179, 1200–1201, 1255–1256, 1258–1259, 1298, 1300, 1318–1319, 1321–1322, 1325–1326, 1329, 1331–1332
TOTAL75431757% 

Tests Skipped Failures Errors Time
55 0 💤 0 ❌ 0 🔥 2.522s ⏱️

@almog2296 almog2296 added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Feb 4, 2026
@content-bot content-bot removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Feb 4, 2026
@content-bot
Copy link
Contributor

content-bot commented Feb 4, 2026

🤖 Content AI Reviewer: Analysis started. Please wait for results...

@content-bot
Copy link
Contributor

content-bot commented Feb 4, 2026

🤖 Content-bot Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

content-bot
content-bot reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

@content-bot content-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the contribution to the Okta integration. I've reviewed the changes and have a few recommendations to align with our standards.

Please update the boolean argument in the YAML to use type: 8 (Boolean) instead of a predefined list for a better user experience. In the unit tests, I recommend testing the command function directly rather than the client method to ensure argument parsing logic is verified. Lastly, please adjust the Release Notes formatting and ensure the README argument names match the command table.

Great work otherwise!

Additionally, please address the following file-level notes:

  • Packs/Okta/Integrations/Okta_v2/Okta_v2_test.py: The new unit tests (test_clear_user_sessions_with_oauth_tokens) appear to call the client method directly. It is recommended to test the command function clear_user_sessions_command instead. This ensures that the argument parsing logic (specifically argToBoolean) is verified along with the client call.

@JudahSchwartz please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@content-bot
Copy link
Contributor

content-bot commented Feb 5, 2026

Validate summary
The following errors were reported as warnings: DO106.
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@content-bot content-bot content-bot left review comments

@JudahSchwartz JudahSchwartz Awaiting requested review from JudahSchwartz JudahSchwartz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@almog2296 @content-bot